[Rollups] Add useNormalizedEsInterval param to date histogram bucket to allow rollups to avoid normalizing ES interval units #24428
Conversation
💔 Build Failed |
|
@timroes Jen and I found another wrinkle we need your feedback on. It looks like Our question is whether this should also hook into the |
…ollups to avoid normalizing ES interval units.
cjcenizal
force-pushed
the
rollups-normalize-interval-bug
branch
from
cc4832d to
66e73da
Compare
|
This doesn't work for me, when I look at about 2 weeks worth of data:
It also doesn't seem to work even if I'm using a smaller date range, but without the same errors: |
|
I looked quickly at it, and I don't have any objections or seeing any obvious issues, also after talking in depth with CJ about that yesterday. Currently don't have time for a full review, so please feel free to merge this also without my complete review. |
💚 Build Succeeded |
|
@spalger Those almost look like time filter errors? Are you able to create a normal (non-rollup index pattern) visualization? I have 60/1 500k makelogs data and am using the rollup job config you sent me yesterday:
Current state of my job as a sanity check. Is there some discrepancy between our setup? |
This PR doesn't do what it's supposed to, but I need some help figuring out why @jen-huang and @timroes.This PR fixes an error in which narrowing the time range of a rollup vis results in an API error due to a fixed time interval being converted to a calendar time interval. To repro the error, create a date histogram visualization using rollup data, with an interval of 60m. Ensure the time range is large enough so that the visualization will render. Brush or otherwise change the time range so that it's very narrow and you get a toast error stating something like
Rollup search error: [illegal_argument_exception] There is not a rollup job that has a [date_histogram] agg on field [utc_time] which also satisfies all requirements of query.This PR is supposed to fix this error, but it doesn't because it looks like we're callingwriteon the date histogram bucket twice in a single render. The first time,useNormalizedEsIntervalis correctly set tofalsebut the second time it looks like it changes totruebut I'm having a hard time figuring out why.EDIT: @jen-huang and I weren't able to reproduce the bug I originally found with this solution. She tested more on her own and still wasn't able to repro. So it appears this solution works.
TODO: